W85 — The Resort Tells You What Needs Attention - #361

Summary

Closes #356. Builds system 19 (alerts), the last of the five stub world-graph tick systems named in design/90-decisions.md's 2026-08-05 known-and-retained entry.

• Achievements (W85.1): still-locked achievements are evaluated by definition id, in the campaign's own canonical (lexicographic) order, against post-resolution state. An unlock writes unlockedAchievementIds.<id>.exists under the core achievement_unlocked reason. Profile mirroring is the existing generic session-store mechanism (upsertAchievements), which only ever runs after a whole action succeeds — proved by a run whose refused advance_ticks leaves the profile untouched.
• Alerts (W85.2–W85.4): exactly three closed families — active incident, broken building, scenario resolved — each keyed on a semantic key built only from the family name plus a published id, never authored text. The two kind-owned families resolve through new world-graph.alert.<type>.title|message built-in strings; incident alerts reuse the incident definition's own name/description keys.
• No duplicates, no leakage (W85.3, W85.5): a source already represented by an uncleared alert never raises a second one (dismissal doesn't free the key — only clearing does); alerts and achievements feed nothing back into the same tick (tested by dropping both before system 20 and diffing the rest of state).
• Audit and events (W85.6): achievement.unlocked, alert.raised, alert.cleared are declared and emitted; alert creation/removal audit rows are hidden (visible: false) per contract.
• Determinism (W85.7): advance_ticks n serializes byte-identically whether submitted whole or split, across a batch that both raises and clears an alert.
• Fixture (W85.8): a new world-graph-mvp-achievement replay fixture proves a real unlock (double-cleaner, gated on hiring two cleaners — inert everywhere else, following the same gating pattern W84's storm incident used). All previously committed outcomes are unchanged byte-for-byte.
• Decision ledger (W85.9): closes out 90-decisions.md's tick-system entry — it also picked up W84's missed amendment for incidents (system 16), so the entry now correctly reads zero systems remaining rather than jumping straight from "two remain" to a nonexistent state.

A resolved contract-vs-code disagreement

20-contract.md §13 specifies the achievement audit path as unlockedAchievementIds.<id>.exists (world-graph's own member-scoped path shape), but the generic session-store matcher (achievementIdFrom in src/engine/src/core/session/store.ts) only recognized achieved.<id> (story-graph's flat convention). Implementing the contract literally would have silently broken profile mirroring for world-graph, with no test in this slice's own file likely to catch it. Resolved (user-confirmed) by widening the matcher to accept both prefixes — each kind keeps its own contract-literal path shape.

Follow-up commits

• d347ba5 — code review fixes: alerts()'s achievement-unlock and alert-clear loops moved to Set-driven passes (matching the pattern story-graph/achievements.ts already established), and reasons.ts's deliberately-unregistered list now names alert_raised/alert_cleared alongside the other visible: false reasons.
• bfdf226 — regenerated docs/docs/engine/12-world-graph-kind.md and docs/docs/guide.md from design/20-contract.md's §12 edit, which the initial commit had made without carrying through the generation workflow.

Touches

• src/engine/src/kinds/world-graph/tick/pipeline.ts — system 19 (alerts)
• src/engine/src/kinds/world-graph/kind.ts — eventNames
• src/engine/src/kinds/world-graph/reasons.ts — kind-owned alert strings
• src/engine/src/campaigns/world-graph-mvp.ts — the double-cleaner achievement
• src/engine/src/core/session/store.ts — widened achievement path matcher
• New fixture pair under src/engine/fixtures/replay/
• design/20-contract.md, design/90-decisions.md — descriptive corrections (§12 event-table status rows for the three delivered events; the tick-system register closed out)
• docs/docs/engine/12-world-graph-kind.md, docs/docs/guide.md — regenerated from the design/20-contract.md edit above

Verified

Ran and passed:

• Typecheck — npm --prefix src/engine run typecheck (tsc --noEmit && tsc --noEmit -p tsconfig.scripts.json) — exit 0
• Lint — npm --prefix src/engine run lint (eslint src scripts) — exit 0
• Test — npm --prefix src/engine test (vitest run) — Test Files 79 passed (79), Tests 1146 passed (1146)
• Pack package — npm pack --silent produced the-running-dev-game-engine-0.10.0.tgz, exit 0
• Inspect tarball — no src/, no tsconfig*.json, no .test.* build artifacts; package/dist/ present
• Consumer smoke — install:engine && build && smoke all exited 0
• Parse-check PowerShell scripts — every *.ps1 parsed with 0 errors
• Run Pester tests — 235 passed, 0 failed, 18 skipped
• Validate Markdown links, terminology, and generated files — ./build/Test-Documentation.ps1: human-documentation drift check passed across 18 generated engine page(s), compatibility pointers, and the guide; documentation checks passed across 123 Markdown file(s)
• Build and verify landing page — npm --prefix site run check (format:check, lint, typecheck, test, test:browser via Playwright, test:build, test:merge) — all passed

Did not run locally (each has a corresponding CI check on this PR, all green — Build, run, and smoke the image, Verify Documentation Build):

• Build documentation — needs the docs-template container image; docs.ps1 (the local wrapper) is absent from this checkout per CLAUDE.md (installer-generated, not committed).
• Merge landing page into documentation build — depends on the docs build above.
• Test the host / Positive route and probe smoke / Negative fixture — need NUGET_GITHUB_TOKEN to restore SubZeroDev.Platform.Hosting from the sibling repository's GitHub Packages feed; not set locally.

Actual PR checks (confirming the above): engine pass, powershell pass, Documentation links and terminology pass, Verify Documentation Build pass, Build, run, and smoke the image pass.

Test plan

• Unit: achievement unlock, non-re-unlock, all three alert families, key derivation, no-duplicate/clear cycle, audit visibility, no-downstream-leakage (pipeline.test.ts)
• Integration: profile mirroring on success vs. refusal, byte-identical batch split across a raise/clear cycle (kind.test.ts)
• Replay: existing 6 fixtures unchanged; new world-graph-mvp-achievement fixture matches its committed outcome